Group Admins
Wiki is Slow to Load
- This topic has 20 replies, 5 voices, and was last updated 10 years, 4 months ago by
.
-
I believe I found what is causing this problem. The issue starts with the document list at the bottom of the wiki home page:
We have two pages that show up on that list often which each contain a lot of attachments (around 200 combined). After digging through some code I’ve found that the function bp_docs_doc_attachment_drawer (buddypress-docs/includes/templatetags.php) is called on that page, which in turn calls bp_docs_attachement_item_markup for each attachment that is on that page. …item_markup calls bp_docs_get_attachment_url, which calls bp_docs_attachment_protection, which finally calls check_is_protected (buddypress-docs/includes/attachments.php).
check_is_protected attempts to access a file it shouldn’t have access to (hence checking for protection) and is issued a 302 redirect if it fails. In our case when we have around 200 attachments on the home page of the wiki wp_remote_get is called 200 times, and then is issued a 302 redirect which then loads the redirect page 200 times. This totals over 400 page loads just to load the home page of the wiki. This is why the home page of our wiki takes ages to load if I don’t circumvent the check_is_protected function by returning true on the first line of it.
Please let me know if there is a better way to handle this, if this is a bug, etc.
Thanks,
Matt
@cbox_admin – Sorry for the delay, but I have finally checked the things you have asked of me.
– is $force_check indeed defaulting to false on these calls?
Yes, I checked this and force_checked == false for every call that takes place on the wiki home page. However, on the next part of the function (the ‘ ‘ === $is_protected):
// Fall back on cached value if it exists
if ( ! $force_check ) {
$is_protected = bp_get_option( ‘bp_docs_attachment_protection’ );
if ( ” === $is_protected ) {
return (bool) $is_protected;
}
}is not evaluating as true, so the function is not returning there.
– is the .htaccess file being created as expected?
If I remove the .htaccess file that is in uploads/bp-attachments/0 then there is no slow down and the file is not recreated. When i put the file back with the following rules:
RewriteEngine On
RewriteBase /
RewriteRule (.+) ?bp-attachment=$1 [R=302,NC]
it slows down the load of the wiki. It looks like to me that with the .htaccess file removed the function never gets to the point where it can recreate it since it has to pass this check first:if ( ! file_exists( $test_file_dir ) ) {
Since the test.html file still exists even though the.htaccess file is gone (or even if the .htaccess file is there) this condition is never met. This may be its own bug?
– what is the return value of the wp_remote_get() call?
Array
(
[headers] => Array
(
[date] => Mon, 25 Aug 2014 13:34:26 GMT
[server] => Apache/2.2.22 (Ubuntu)
[last-modified] => Tue, 01 Jul 2014 17:24:36 GMT
[etag] => “e1f8b-5c-4fd250cbfedd9”
[accept-ranges] => bytes
[content-length] => 92
[vary] => Accept-Encoding
[connection] => close
[content-type] => text/html
)[body] => This is a test of the Protected Attachment feature of BuddyPress Docs. Please do not remove.
[response] => Array
(
[code] => 200
[message] => OK
)[cookies] => Array
(
)[filename] =>
)– when bp_update_option() is run, is it returning true or false?
It doesn’t seem to be returning anything. It doesn’t look like that function has a return type –
buddypress/bp-core/bp-core-options.php, line 262:function bp_update_option( $option_name, $value ) {
update_blog_option( bp_get_root_blog_id(), $option_name, $value );
}Please let me know if there is anything else I can do to help out!
Matt
- You must be logged in to reply to this topic.
